Stats: fix UTM upsell overlay link

CGastrell commented 1 day ago

Related to #87925

Proposed Changes

Implement "Learn more" link on the UTM upsell overlay. Odyssey won't render Calypso components, so we choose between the InlineSupportLink or a simple link to support page depending on the case.

Why are these changes being made?

Ref: https://github.com/Automattic/red-team/issues/194 Ref: pe4Cmx-2SM-p2

Part of the PT/tasks assigned to Agora team https://github.com/Automattic/red-team/issues/203#event-15156617447

Testing Instructions

The UTM card shows an overlay when no upgrade/plan is purchased. The overlay should now show a "Learn more" link.

On Calypso, it should open the floating support popup:

On Jetpack Odyssey Stats it should open the support page in a new tab (see link address at the bottom):

Pre-merge Checklist

[ ] Has the general commit checklist been followed? (PCYsg-hS-p2)
[ ] Have you written new tests for your changes?
[ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
[ ] Have you checked for TypeScript, React or other console errors?
[ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
[ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
[ ] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions[bot] commented 1 day ago

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-6dcb49a65c5c8b17751858d294c9c85635f9a29d

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-6dcb49a65c5c8b17751858d294c9c85635f9a29d&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-6dcb49a65c5c8b17751858d294c9c85635f9a29d&env=a8c-for-agencies

matticbot commented 1 day ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~104 bytes added 📈 [gzipped])

``` name parsed_size gzip_size stats +329 B (+0.0%) +104 B (+0.0%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1755 bytes added 📈 [gzipped])

``` name parsed_size gzip_size async-load-store-app-store-stats-listview +3209 B (+1.2%) +951 B (+1.2%) async-load-store-app-store-stats +3196 B (+0.8%) +912 B (+0.8%) ``` React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

**Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

a8ci18n commented 18 hours ago

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17011212

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @CGastrell for including a screenshot in the description! This is really helpful for our translators.

Automattic / wp-calypso