Closed dhasilva closed 14 hours ago
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:
Sections (~826 bytes added 📈 [gzipped])
Legend
Generated by performance advisor bot at iscalypsofastyet.com.
So I created a new one and tried again. Still, neither pre-fill the campaign field.
Hey there, Anna :wave:
Did you select "Campaign / Source / Medium"? By default it is only "Source / Medium", so we don't have the value for the campaign there.
I tried again here and this is what I got:
In this case, campaign is not there as it is not selected in the filter, that is expected behavior.
In this case we have the value for the campaign ("promotion", I should have used another value as that is the same one as the placeholder :sweat_smile:), so it is added to the modal.
That kinda confused me sometimes, @kangzj. "Should I call it URL builder as it builds a URL? UTM builder as that is the name of the modal? Or UTM URL builder to be more specific? :thinking:"
It is a good idea to standardize it, yes.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17011647
Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.
Thank you @dhasilva for including a screenshot in the description! This is really helpful for our translators.
@dhasilva you're totally right, that's exactly what was happening. It makes sense why, but is also confusing I think from a user perspective initially.
Idea: maybe when parsing a link on the UTM form, do not show inputs/fields that are not being used to group the results?
@CGastrell I think this is a great idea and we should consider something like this.
Related to https://github.com/Automattic/red-team/issues/263 Closes https://github.com/Automattic/red-team/issues/263
Proposed Changes
Why are these changes being made?
Testing Instructions
Pre-merge Checklist