Plans: Remove references to `withDiscount` in favor of `coupon`

[jeyip]

Related to https://github.com/Automattic/wp-calypso/issues/95702 and https://github.com/Automattic/wp-calypso/pull/95703 and pau2Xa-6sB-p2#comment-16318

Proposed Changes

Emails rely on the discount query param to auto-apply coupons when redirecting to the logged in plans page. The /start onboarding flow plans page, however, relies on the coupon query param for the same purpose. Although behind the scenes we'll continue to support both coupon and discount for the time being on the logged in plans page ( to accommodate legacy outbound marketing emails ), we'll be consolidating to only coupon in the future.

Because of this, we replace instances of the term withDiscount with the term coupon.

These changes also simplify the feature we're implementing here. Refactoring this code allows us to pass a coupon query param prop into PlansFeaturesMain under the name coupon which is already being used throughout the component ( instead of needing to use withDiscount ).

Why are these changes being made?

• We're moving away from usage of the discount query param. We're only supporting it behind the scenes because of existing email marketing that is using the term. We'll be using the term coupon instead, which is already widely implemented throughout /start onboarding
• Reduce cognitive overhead

Testing Instructions

This is a refactoring PR. There should be no functional changes.

• Smoke test applying coupons in /start onboarding and purchasing a plan with said coupon ( Ex. /start/plans?coupon=federate25 )
• Verify that plans grid pricing is updated to reflect the coupon
• Verify that a plan can be purchased with the coupon auto applied at checkout
• Smoke test applying coupons in the logged in plans page with the ?discount and ?coupon query params
• Note that you won't see updated pricing in the plans grid in this case because we're currently implementing that functionality in https://github.com/Automattic/wp-calypso/pull/96600
• Verify that a plan can be purchased with the discount / coupon auto applied at checkout

Pre-merge Checklist

• [ ] Has the general commit checklist been followed? (PCYsg-hS-p2)
• [ ] Have you written new tests for your changes?
• [ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• [ ] Have you checked for TypeScript, React or other console errors?
• [ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• [ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• [ ] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions[bot]]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125338

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125338&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125338&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~21 bytes removed 📉 [gzipped])

``` name parsed_size gzip_size plans -123 B (-0.0%) -21 B (-0.0%) update-design-flow -93 B (-0.0%) -17 B (-0.0%) plugins -93 B (-0.0%) -17 B (-0.0%) link-in-bio-tld-flow -93 B (-0.0%) -17 B (-0.0%) jetpack-app -93 B (-0.0%) -17 B (-0.0%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~17 bytes removed 📉 [gzipped])

``` name parsed_size gzip_size async-load-signup-steps-plans-theme-preselected -93 B (-0.0%) -17 B (-0.0%) async-load-signup-steps-plans -93 B (-0.0%) -17 B (-0.0%) ``` React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

**Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[jeyip]

@chriskmnds looking for a confidence check with these changes. I made updates several weeks ago to pass the coupon query param from the logged in plans page to checkout https://github.com/Automattic/wp-calypso/pull/95630. Previously, it wasn't working as expected. pau2Xa-6sB-p2#comment-16318

This PR is meant to continue tidying up surrounding code and make the feature change in https://github.com/Automattic/wp-calypso/pull/95703 cleaner.

[jeyip]

tested /plans/:site?coupon=federate25 but can see the discount visible on all plans. is this expected, something off on my end?

Hmmm...definitely odd. Not seeing it on my end but will investigate 😅

Edit:

I'm unsure where the discount originates from. I notice that the one time discount is being applied to all plans in your screenshot and it's for ~9% off. federate25 should only apply 25% to Business and Commerce plans, so it seems unlikely related to the coupon query param changes.

I suspect this might be some sort of store sandbox strangeness, but can't manage to replicate. Would you mind clearing your browser cache and testing the logged in plans page again?

What I've tried so far to emulate:

• Switch currency to Euros
• Check /start/onboarding and logged in /plans
• Enable and disable sandbox
• Enable and disable USE_STORE_SANDBOX
• Test in local dev and calypso.live

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/with-discount-prop-from-plans-grid on your sandbox.