Enable Bulk Plugin Management: Fix the updateable sites count displayed

[vykes-mac]

Closes https://github.com/Automattic/dotcom-forge/issues/9811

Proposed Changes

This PR ensure the correct number of updateable site is displayed in the update modal and also ensure the update call to action is only shown on updateable sites in the sites list modal.

This modal

Sites list modal was showing upadate CTA on sites that are not updateable

This modal was showing incorrect number of sites being updated

• Fix update count

Why are these changes being made?

See the issue for pre-req setup https://github.com/Automattic/dotcom-forge/issues/9811

• Go to /plugins/manage
• Click the update CTA and verify correct number is shown
• Click the site count to open sites modal then click the update cta
• Verify the modal shows the correct count

Testing Instructions

*

Pre-merge Checklist

• [ ] Has the general commit checklist been followed? (PCYsg-hS-p2)
• [ ] Have you written new tests for your changes?
• [ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• [ ] Have you checked for TypeScript, React or other console errors?
• [ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• [ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• [ ] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions[bot]]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-43961e338619de714a6e53e4a9f276e6db31aef5

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-43961e338619de714a6e53e4a9f276e6db31aef5&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-43961e338619de714a6e53e4a9f276e6db31aef5&env=a8c-for-agencies

[vykes-mac]

I think we need to change the copy for this modal, It feels like the count should represent the number of sites the plugin is installed on but it also mentioned update which can be read as the number of sites that will be updated.

was the intent to communicate sites that will be updated or sites the plugin is installed on? 🤷

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~111 bytes added 📈 [gzipped])

``` name parsed_size gzip_size plugins +341 B (+0.0%) +111 B (+0.0%) jetpack-cloud-plugin-management +341 B (+0.0%) +111 B (+0.0%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

**Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.