Untangling: apply new design to Marketing -> Connections

[fushar]

Fixes https://github.com/Automattic/dotcom-forge/issues/9857

Proposed Changes

This PR attempts to apply the design from p9Jlb4-f3i-p2 to Marketing -> Connections.

Before	After

@matt-west, for consistency, for this iteration, I didn't update the button colors:

This is because the rest of /sites pages are not using that scheme, so it would be weirder. I'm proposing to update the colors together with all other screens. Thoughts?

Why are these changes being made?

pbxlJb-6ye-p2

Testing Instructions

1. Go to /sites
2. Select a site (which is not Atomic Classic)
3. Go to Marketing -> Connections
4. Play around with the connections

Pre-merge Checklist

• [x] Has the general commit checklist been followed? (PCYsg-hS-p2)
• [x] Have you written new tests for your changes?
• [x] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• [x] Have you checked for TypeScript, React or other console errors?
• [x] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• [x] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• [x] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions[bot]]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125257

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125257&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125257&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• command-palette-wp-admin
• help-center
• notifications
• odyssey-stats
• whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug untangling/marketing-connections-design on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1906 bytes added 📈 [gzipped])

``` name parsed_size gzip_size jetpack-social +1016 B (+0.2%) +226 B (+0.1%) site-profiler +666 B (+0.2%) +104 B (+0.1%) performance-profiler +666 B (+0.2%) +114 B (+0.1%) jetpack-cloud-manage-pricing +666 B (+0.2%) +198 B (+0.2%) write-flow +280 B (+0.0%) +58 B (+0.0%) update-design-flow +280 B (+0.0%) +83 B (+0.0%) site-tools +280 B (+0.0%) +32 B (+0.0%) site-performance +280 B (+0.0%) +62 B (+0.0%) settings-writing +280 B (+0.0%) +60 B (+0.0%) settings-security +280 B (+0.1%) +41 B (+0.0%) security +280 B (+0.0%) +44 B (+0.0%) scan +280 B (+0.0%) +75 B (+0.0%) plugins +280 B (+0.0%) +79 B (+0.0%) plans +280 B (+0.0%) +79 B (+0.0%) media +280 B (+0.0%) +61 B (+0.0%) link-in-bio-tld-flow +280 B (+0.0%) +82 B (+0.0%) jetpack-search +280 B (+0.0%) +75 B (+0.0%) jetpack-connect +280 B (+0.0%) +80 B (+0.0%) jetpack-cloud-settings +280 B (+0.0%) +54 B (+0.0%) jetpack-cloud-pricing +280 B (+0.0%) +60 B (+0.0%) jetpack-cloud-plugin-management +280 B (+0.0%) +57 B (+0.0%) jetpack-cloud-partner-portal +280 B (+0.0%) +75 B (+0.0%) jetpack-cloud-overview +280 B (+0.1%) +45 B (+0.0%) jetpack-cloud-features-comparison +280 B (+0.0%) +67 B (+0.0%) jetpack-cloud-agency-sites-v2 +280 B (+0.0%) +75 B (+0.0%) jetpack-app +280 B (+0.1%) +79 B (+0.1%) import +280 B (+0.0%) +30 B (+0.0%) home +280 B (+0.0%) +56 B (+0.0%) github-deployments +280 B (+0.0%) +32 B (+0.0%) export +280 B (+0.1%) +53 B (+0.1%) earn +280 B (+0.0%) +66 B (+0.0%) domains +280 B (+0.0%) +77 B (+0.0%) copy-site-flow +280 B (+0.0%) +27 B (+0.0%) concierge +280 B (+0.1%) +37 B (+0.0%) comments +280 B (+0.0%) +32 B (+0.0%) checkout +280 B (+0.0%) +60 B (+0.0%) build-flow +280 B (+0.0%) +66 B (+0.0%) backup +280 B (+0.0%) +75 B (+0.0%) activity +280 B (+0.0%) +68 B (+0.0%) a8c-for-agencies-sites +280 B (+0.0%) +75 B (+0.0%) a8c-for-agencies-referrals +280 B (+0.0%) +83 B (+0.0%) a8c-for-agencies-overview +280 B (+0.0%) +32 B (+0.0%) a8c-for-agencies-migrations +280 B (+0.0%) +52 B (+0.0%) a8c-for-agencies-marketplace +280 B (+0.0%) +75 B (+0.0%) site-marketing +105 B (+0.0%) +17 B (+0.0%) transferring-hosted-site-flow -103 B (-0.1%) -8 B (-0.0%) marketing +43 B (+0.0%) +0 B ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~707 bytes added 📈 [gzipped])

``` name parsed_size gzip_size async-load-signup-steps-clone-point +679 B (+0.4%) +115 B (+0.3%) async-load-signup-steps-page-picker +666 B (+0.2%) +116 B (+0.1%) async-load-purchase-modal-wrapper +666 B (+0.2%) +119 B (+0.1%) async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou... +666 B (+0.2%) +224 B (+0.2%) async-load-calypso-my-sites-checkout-modal +666 B (+0.1%) +114 B (+0.0%) async-load-signup-steps-plans-theme-preselected +280 B (+0.1%) +79 B (+0.1%) async-load-signup-steps-plans +280 B (+0.1%) +79 B (+0.1%) async-load-signup-steps-domains +280 B (+0.1%) +24 B (+0.0%) async-load-design-playground +280 B (+0.0%) +35 B (+0.0%) async-load-design-blocks +280 B (+0.0%) +61 B (+0.0%) async-load-design +280 B (+0.0%) +35 B (+0.0%) async-load-calypso-post-editor-media-modal +280 B (+0.0%) +61 B (+0.0%) async-load-calypso-post-editor-editor-media-modal +280 B (+0.0%) +61 B (+0.0%) async-load-calypso-blocks-editor-checkout-modal +280 B (+0.0%) +60 B (+0.0%) ``` React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

**Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[taipeicoder]

Maybe padding would make it more consistent to here?

[fushar]

Thanks, but I think I prefer to remove the bottom margin to be self-consistent with the following notice

[matt-west]

for consistency, for this iteration, I didn't update the button colors

No problem. I agree that we should update these across all of Dotcom for consistency.