Add upsell to Advanced Tools tab

madhusudhand commented 18 hours ago

Fixes: https://github.com/Automattic/dotcom-forge/issues/9866

Proposed Changes

Add a new route /sites/tools/:site
Re-use the contents of Hosting features in advanced tools

Why are these changes being made?

Part of untangling hosting menu

Testing Instructions

*

Pre-merge Checklist

[ ] Has the general commit checklist been followed? (PCYsg-hS-p2)
[ ] Have you written new tests for your changes?
[ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
[ ] Have you checked for TypeScript, React or other console errors?
[ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
[ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
[ ] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions[bot] commented 18 hours ago

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125272

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125272&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125272&env=a8c-for-agencies

matticbot commented 18 hours ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug feature/advanced-tools on your sandbox.

matticbot commented 18 hours ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~12 bytes added 📈 [gzipped])

``` name parsed_size gzip_size entry-main +279 B (+0.0%) +45 B (+0.0%) entry-domains-landing +139 B (+0.0%) +66 B (+0.0%) entry-browsehappy +139 B (+0.1%) +66 B (+0.1%) entry-stepper -45 B (-0.0%) +12 B (+0.0%) entry-subscriptions +20 B (+0.0%) +39 B (+0.0%) entry-login +20 B (+0.0%) +39 B (+0.0%) ``` Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~56435 bytes removed 📉 [gzipped])

``` name parsed_size gzip_size site-tools +46691 B (+2.8%) +14745 B (+3.1%) hosting-features +1144 B (+0.1%) +1186 B (+0.3%) signup +548 B (+0.2%) +12 B (+0.0%) update-design-flow +394 B (+0.0%) -5 B (-0.0%) link-in-bio-tld-flow +352 B (+0.0%) -815 B (-0.2%) start-writing-flow -216 B (-0.8%) -21 B (-0.4%) design-first-flow -216 B (-0.8%) -19 B (-0.3%) write-flow -196 B (-0.0%) -827 B (-0.3%) build-flow -196 B (-0.0%) -827 B (-0.3%) staging-site +186 B (+0.0%) +67 B (+0.0%) themes +163 B (+0.0%) +1013 B (+0.3%) with-theme-assembler-flow -154 B (-0.2%) -15 B (-0.1%) update-options-flow -154 B (-0.3%) -12 B (-0.2%) trial-wooexpress-flow -154 B (-0.3%) -15 B (-0.2%) tailored-ecommerce-flow -154 B (-0.3%) -12 B (-0.2%) site-setup-wg -154 B (-0.1%) -13 B (-0.1%) site-setup-flow -154 B (-0.1%) -13 B (-0.1%) site-migration-flow -154 B (-0.2%) -8 B (-0.1%) readymade-template-flow -154 B (-0.1%) -14 B (-0.0%) migration-signup -154 B (-0.2%) -12 B (-0.1%) migration-flow -154 B (-0.2%) -8 B (-0.1%) import-flow -154 B (-0.2%) -17 B (-0.2%) hosted-site-migration-flow -154 B (-0.2%) -8 B (-0.1%) free-post-setup-flow -154 B (-0.3%) -13 B (-0.2%) entrepreneur-flow -154 B (-0.1%) -14 B (-0.0%) assembler-first-flow -154 B (-0.2%) -31 B (-0.2%) ai-assembler-flow -154 B (-0.2%) -20 B (-0.1%) theme +133 B (+0.0%) +838 B (+0.4%) plugins -125 B (-0.0%) +1038 B (+0.1%) jetpack-cloud-plugin-management -125 B (-0.0%) +1038 B (+0.2%) newsletter-flow -108 B (-0.5%) -25 B (-0.4%) site-settings -101 B (-0.0%) -1024 B (-0.2%) scan +97 B (+0.0%) +711 B (+0.3%) backup +97 B (+0.0%) +669 B (+0.2%) a8c-for-agencies-sites +97 B (+0.0%) +669 B (+0.1%) sites-dashboard +95 B (+0.0%) +56 B (+0.0%) site-performance +95 B (+0.0%) +146 B (+0.0%) github-deployments +95 B (+0.0%) +212 B (+0.1%) settings -93 B (-0.0%) -1006 B (-0.3%) site-monitoring +48 B (+0.0%) +363 B (+0.1%) site-logs +48 B (+0.0%) +180 B (+0.0%) stats -39 B (-0.0%) -32 B (-0.0%) settings-performance +34 B (+0.0%) +1056 B (+0.6%) hosting +32 B (+0.0%) -386 B (-0.1%) home -32 B (-0.0%) -293 B (-0.1%) site-marketing +30 B (+0.0%) +100 B (+0.0%) devdocs +30 B (+0.0%) +46 B (+0.1%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~4246 bytes added 📈 [gzipped])

``` name parsed_size gzip_size async-load-signup-steps-design-picker +196 B (+0.4%) +680 B (+3.8%) async-load-calypso-state-lib-automated-transfer-middleware -192 B (-0.9%) -552 B (-8.3%) async-load-signup-steps-woocommerce-install-confirm -37 B (-0.1%) +213 B (+1.2%) async-load-signup-steps-theme-selection +30 B (+0.0%) +371 B (+0.3%) ``` React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

**Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Automattic / wp-calypso