Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

A4A: Implement Agency ownership transfer #96612

Open tiagonoronha opened 15 hours ago

tiagonoronha commented 15 hours ago

Adds the possibility to transfer the Agency Owner role to a different team member on the agency account.

Related to https://github.com/Automattic/automattic-for-agencies-dev/issues/1128.

Proposed Changes

Screenshot 2024-11-21 at 10 38 49 Screenshot 2024-11-21 at 10 38 39

Testing Instructions

Pre-merge Checklist

github-actions[bot] commented 15 hours ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-8bae9311e2e258ca02b6cc0fff6445a0fdf7733a
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-8bae9311e2e258ca02b6cc0fff6445a0fdf7733a&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-8bae9311e2e258ca02b6cc0fff6445a0fdf7733a&env=a8c-for-agencies
matticbot commented 15 hours ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~183 bytes added 📈 [gzipped])

``` name parsed_size gzip_size a8c-for-agencies-team +1144 B (+0.1%) +183 B (+0.1%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

cleacos commented 7 hours ago

I've tested it partially (I have issues with my sandbox). I can select the Transfer ownership option and I see the confirm modal. The code looks good.