Fixed the upsells on premium themes

[rcrdortiz]

Related to:

• https://github.com/Automattic/wp-calypso/issues/96595

Proposed Changes

• Changed the logic to show the Try before you buy screen.
• When the GS on Personal feature is enabled, only users on the Free plan viewing a Free theme with style variations will see the modal.

Why are these changes being made?

• Production bug

Testing Instructions

• Open the Calypso live link
• Create a new site
• You should see that Premium and Personal themes always trigger a plan upgrade
• Free themes will display the GS upsell when a style variation is selected.

https://github.com/user-attachments/assets/f7fcb5fe-65b1-430c-9839-8a0fd1da74a7

Pre-merge Checklist

• [ ] Has the general commit checklist been followed? (PCYsg-hS-p2)
• [ ] Have you written new tests for your changes?
• [ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• [ ] Have you checked for TypeScript, React or other console errors?
• [ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• [ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• [ ] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions[bot]]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125273

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125273&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125273&env=a8c-for-agencies

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[rcrdortiz]

Solves the bug, thank you!

An improvement would be to use different wording about gs because they no longer need separate unlocking (like premium plan themes do)

Personal Premium Could be done as a follow-up though.

I was planning on re-visiting the upgrade pills in this issue: https://github.com/Automattic/dotcom-forge/issues/9676 Before our changes there already were some issues on the DP. I have it marked as a Good first issue so that Antonio can work on it and get familiar with Calypso.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/premium-themes-upsell on your sandbox.