Open robfelty opened 13 hours ago
https://calypso.live?image=registry.a8c.com/calypso/app:build-125282&env=jetpack |
https://calypso.live?image=registry.a8c.com/calypso/app:build-125282&env=a8c-for-agencies |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:
Async-loaded Components (~50 bytes added 📈 [gzipped])
Legend
Generated by performance advisor bot at iscalypsofastyet.com.
This PR modifies the release build for the following Calypso Apps:
For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/odie-traintracks
on your sandbox.
In doing analysis on the Tracks events for odie sources, I noticed several issues
Proposed Changes
Why are these changes being made?
Testing Instructions
First, to see the issue:
t.gif
t.gif
pixel requests with event name_en=calypso_odie_sources_traintracks_render
. There should be 0 at this pointNow, to see the fix:
t.gif
events (there will be some other events but nocalypso_odie_sources_traintracks_render
eventscalypso_odie_sources_traintracks_render
events, probably 10 - one for each source that Odie found. It could be less, depending on the query. Confirm that the missing event properties are now there.Pre-merge Checklist