Plans (grid): Disable term-savings price display if another discount is active (intro/coupon/etc.)

chriskmnds commented 3 days ago

Proposed Changes

This is a follow-up to the term-savings price display (see core implementation: https://github.com/Automattic/wp-calypso/pull/96357) to disable the term-savings display if any plan, across any available/effective term for the rendered grid appears as discounted already.

See related discussion: pdvytD-Se-p2#comment-645. Implementation directly addresses comment pdvytD-Se-p2#comment-650:

a plan on a "one time discount" coupon will disable the term-savings
a plan on a "special offer" introductory offer will disable the term-savings
term-savings are disabled for all the plans, so switching between monthly/yearly/2yearly/3yearly will not resurface the term-savings, as long as any visible plan is discounted

Why are these changes being made?

Avoid confusion when plans are discounted while the term-savings display is active. Keep the focus on the effective/promoted discount across the user's interaction with the grid.

See related discussion: pdvytD-Se-p2#comment-645. Implementation directly addresses comment pdvytD-Se-p2#comment-650

Testing Instructions

TBD - WIP

Pre-merge Checklist

[ ] Has the general commit checklist been followed? (PCYsg-hS-p2)
[ ] Have you written new tests for your changes?
[ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
[ ] Have you checked for TypeScript, React or other console errors?
[ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
[ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
- [ ] For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
[ ] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions[bot] commented 3 days ago

Link to live branch is being generated... Please wait a few minutes and refresh this page.

chriskmnds commented 2 days ago

@jeyip This is a pretty insane change. If this is where we want things to head, then I'll continue pushing through more surrounding refactors. I think this is where we want things to head, conceptually.

cc @southp as something to keep an eye on. The primary consideration going forward should on maintaining the memoization of the affected hooks. Otherwise, it literally can be 4x the processing on any interaction (if not already - needs to be tested). 🤷

chriskmnds commented 2 days ago

@jeyip This is a pretty insane change. If this is where we want things to head, then I'll continue pushing through more surrounding refactors. I think this is where we want things to head, conceptually.

cc @southp as something to keep an eye on. The primary consideration going forward should on maintaining the memoization of the affected hooks. Otherwise, it literally can be 4x the processing on any interaction (if not already - needs to be tested). 🤷

Well, I'm going to experiment with another approach. This feels a little over the line.

jeyip commented 2 days ago

@jeyip This is a pretty insane change. If this is where we want things to head, then I'll continue pushing through more surrounding refactors. I think this is where we want things to head, conceptually.

Well, I'm going to experiment with another approach. This feels a little over the line.

Thanks for exploring this change. Pretty unfortunate that it gets crazy. I haven't reviewed the code yet, but I'll take a closer look before I sign off

Automattic / wp-calypso