Closed leonardost closed 7 hours ago
https://calypso.live?image=registry.a8c.com/calypso/app:build-125317&env=jetpack |
https://calypso.live?image=registry.a8c.com/calypso/app:build-125317&env=a8c-for-agencies |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:
Sections (~12 bytes added 📈 [gzipped])
Async-loaded Components (~12 bytes added 📈 [gzipped])
Legend
Generated by performance advisor bot at iscalypsofastyet.com.
This PR modifies the release build for the following Calypso Apps:
For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/hide-domain-suggestion-error-if-tld-is-supported-in-gravatar-flow
on your sandbox.
This doesn't work when the TLDs aren't loaded in the global state (you can add the flags=force-sympathy
URL parameter to clear the state). Abandoning this in favor of #96641 or #96648.
Proposed Changes
This PR cleans the suggestion error message in the Gravatar domain flow if the TLD of the domain being searched is supported.
Why are these changes being made?
If you visit the Gravatar flow with a domain with an unsupported TLD (e.g.
/start/domain-for-gravatar/domain-only?search=yes&new=test202411212.net
), an error notice should be shown. If you visit the Gravatar flow again with a domain with a supported TLD (e.g./start/domain-for-gravatar/domain-only?search=yes&new=test202411212.link
), the error message will still be showing. This PR fixes that problem.Testing Instructions
/start/domain-for-gravatar/domain-only?search=yes&new=test202411212.net
and ensure the error notice is shown/start/domain-for-gravatar/domain-only?search=yes&new=test202411212.link
and ensure the error notice is not shownPre-merge Checklist