Open andregardi opened 3 days ago
https://calypso.live?image=registry.a8c.com/calypso/app:build-125468&env=jetpack |
https://calypso.live?image=registry.a8c.com/calypso/app:build-125468&env=a8c-for-agencies |
This PR modifies the release build for the following Calypso Apps:
For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run install-plugin.sh $pluginSlug agardi/app-password-credentials-step
on your sandbox.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:
App Entrypoints (~58 bytes added 📈 [gzipped])
Sections (~866 bytes added 📈 [gzipped])
Legend
Generated by performance advisor bot at iscalypsofastyet.com.
Related to https://github.com/Automattic/wp-calypso/issues/96564
Proposed Changes
As part of application passwords integration on migrations, we are refactoring the credentials step. If application passwords is available on the source site, users may not be required to input admin username and password.
Under the
automated-migration/application-password
feature flag we are removing the username and password fields. We are planning to have an additional step to collect those in case application passwords approval is not available.Conditionally to the feature flag, we are also preventing the call to
useRequestAutomatedMigration
which should be done in a posterior step. Either theGet ready for blazing fast speeds
orSecurely share your credentials
which are still to be built.If the site is not Wordpress platform at all, we should direct the user to the
Looks like there's been a mix-up
step.If the site is already a WPCOM site we redirect, we should redirect to the
Your site is already on WordPress.com
survey step.Testing Instructions
The
automated-migration/application-password
feature flag is already on localhost environment. Start a Do it for me migration until you reach the/site-migration-credentials
step. Password and usernames should not be present anymore.Keep using the valid source site address and click on Continue button. You should be redirected to a
Get ready for blazing fast speeds
step. This step should be empty, it is just a placeholder for future implementation.Click on back button. Try a URL that is not a wordpress platform site. For example
https://automattic.tumblr.com/
. You should be directed toLooks like there's been a mix-up
step.Click on back button. Try a URL that is already on WPCOM site. For example
https://matt.blog/
. You should be directed to theYour site is already on WordPress.com
step.Make a regression test with feature flag disabled, by adding
flags=-automated-migration/application-password
url query parameter. Migration flow should keep working as before.Pre-merge Checklist