Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Fix UTM card learn more link #96651

Open CGastrell opened 4 hours ago

CGastrell commented 4 hours ago

Fallback to external link as InlineSupportLink component refuses to render properly.

Related to #87925 Related to #96596

Proposed Changes

This PR changes the link on UTM card upsell overlay to external support link

Why are these changes being made?

Because InlineSupportLink can't render under specific conditions

Testing Instructions

The UTM card shows an overlay when no upgrade/plan is purchased. The overlay should now show a "Learn more" link.

Odyssey stats was already showing this link, yet Calypso failed to render it. Test on calypso.localhost:3000/stats/day/some-site-of-yours

Before:

image

After:

image

Verify that Odyssey Stats continues to work visiting some.site.of.yours/wp-admin/admin.php?page=stats#!/stats/day/some.site.of.yours

Pre-merge Checklist

github-actions[bot] commented 4 hours ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125332
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125332&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125332&env=a8c-for-agencies
matticbot commented 4 hours ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~46 bytes removed 📉 [gzipped])

``` name parsed_size gzip_size stats -126 B (-0.0%) -46 B (-0.0%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1693 bytes removed 📉 [gzipped])

``` name parsed_size gzip_size async-load-store-app-store-stats-listview -3002 B (-1.1%) -889 B (-1.1%) async-load-store-app-store-stats -2989 B (-0.8%) -850 B (-0.7%) ``` React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.