Untangling: add subtab upsell to Settings -> Caching

fushar commented 3 days ago

Related to:

https://github.com/Automattic/dotcom-forge/issues/9867

Proposed Changes

This PR adds an upsell to Settings -> Caching subtab based on p9Jlb4-eWT-p2#comment-14261.

Why are these changes being made?

pbxlJb-6ye-p2

Testing Instructions

[!NOTE]
Please don't review the copy; we can iterate on it later!

Go to /sites.
Click a Free site.
Go to Settings -> Caching, verify you see:

Click Upgrade.
Verify you go through the checkout flow and can complete the flow.
Verify you are redirected back to the Caching subtab, and see:

Click Activate now.
Verify you go through the hosting activation flow and can complete the flow.
Verify you are redirected back to the Caching subtab, and see:

REGRESSION: Open another Free site, go to the Hosting Features subtab, and verify you can still upgrade and activate from this subtab.

Pre-merge Checklist

[x] Has the general commit checklist been followed? (PCYsg-hS-p2)
[x] Have you written new tests for your changes?
[x] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
[x] Have you checked for TypeScript, React or other console errors?
[x] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
[x]Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
- [x] For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
[x] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions[bot] commented 3 days ago

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125386

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125386&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125386&env=a8c-for-agencies

matticbot commented 3 days ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

notifications
wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug untangling/subtab-upsells on your sandbox.

matticbot commented 3 days ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~178 bytes added 📈 [gzipped])

``` name parsed_size gzip_size entry-main +815 B (+0.0%) +211 B (+0.0%) entry-stepper +491 B (+0.0%) +178 B (+0.0%) entry-login +415 B (+0.0%) +152 B (+0.0%) entry-domains-landing +280 B (+0.0%) +125 B (+0.1%) entry-browsehappy +280 B (+0.1%) +125 B (+0.2%) entry-subscriptions +161 B (+0.0%) +98 B (+0.0%) ``` Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~62148 bytes removed 📉 [gzipped])

``` name parsed_size gzip_size site-settings +41266 B (+2.6%) +12224 B (+2.8%) hosting-features +1232 B (+0.1%) +1252 B (+0.3%) signup +548 B (+0.2%) +12 B (+0.0%) staging-site +483 B (+0.0%) +164 B (+0.0%) update-design-flow +394 B (+0.0%) -5 B (-0.0%) sites-dashboard +392 B (+0.0%) +153 B (+0.0%) site-performance +392 B (+0.0%) +243 B (+0.1%) site-monitoring +392 B (+0.0%) +277 B (+0.1%) site-logs +392 B (+0.0%) +277 B (+0.1%) github-deployments +392 B (+0.0%) +296 B (+0.1%) site-tools +367 B (+0.0%) +273 B (+0.1%) link-in-bio-tld-flow +352 B (+0.0%) -815 B (-0.2%) hosting +329 B (+0.0%) -289 B (-0.1%) site-marketing +327 B (+0.0%) +197 B (+0.0%) start-writing-flow -216 B (-0.8%) -21 B (-0.4%) design-first-flow -216 B (-0.8%) -19 B (-0.3%) write-flow -196 B (-0.0%) -827 B (-0.3%) build-flow -196 B (-0.0%) -827 B (-0.3%) themes +163 B (+0.0%) +1013 B (+0.3%) with-theme-assembler-flow -154 B (-0.2%) -15 B (-0.1%) update-options-flow -154 B (-0.3%) -12 B (-0.2%) trial-wooexpress-flow -154 B (-0.3%) -15 B (-0.2%) tailored-ecommerce-flow -154 B (-0.3%) -12 B (-0.2%) site-setup-wg -154 B (-0.1%) -13 B (-0.1%) site-setup-flow -154 B (-0.1%) -13 B (-0.1%) site-migration-flow -154 B (-0.2%) -8 B (-0.1%) readymade-template-flow -154 B (-0.1%) -14 B (-0.0%) migration-signup -154 B (-0.2%) -12 B (-0.1%) migration-flow -154 B (-0.2%) -8 B (-0.1%) import-flow -154 B (-0.2%) -17 B (-0.2%) hosted-site-migration-flow -154 B (-0.2%) -8 B (-0.1%) free-post-setup-flow -154 B (-0.3%) -13 B (-0.2%) entrepreneur-flow -154 B (-0.1%) -14 B (-0.0%) assembler-first-flow -154 B (-0.2%) -31 B (-0.2%) ai-assembler-flow -154 B (-0.2%) -20 B (-0.1%) theme +133 B (+0.0%) +838 B (+0.4%) plugins -125 B (-0.0%) +1038 B (+0.1%) jetpack-cloud-plugin-management -125 B (-0.0%) +1038 B (+0.2%) newsletter-flow -108 B (-0.5%) -25 B (-0.4%) scan +97 B (+0.0%) +711 B (+0.3%) backup +97 B (+0.0%) +669 B (+0.2%) a8c-for-agencies-sites +97 B (+0.0%) +669 B (+0.1%) settings -93 B (-0.0%) -1126 B (-0.4%) stats -52 B (-0.0%) -38 B (-0.0%) settings-performance +34 B (+0.0%) +1056 B (+0.6%) home -32 B (-0.0%) -241 B (-0.1%) devdocs +30 B (+0.0%) +46 B (+0.1%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~4246 bytes added 📈 [gzipped])

``` name parsed_size gzip_size async-load-signup-steps-design-picker +196 B (+0.4%) +680 B (+3.8%) async-load-calypso-state-lib-automated-transfer-middleware -192 B (-0.9%) -552 B (-8.3%) async-load-signup-steps-woocommerce-install-confirm -37 B (-0.1%) +213 B (+1.2%) async-load-signup-steps-theme-selection +30 B (+0.0%) +371 B (+0.3%) ``` React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

**Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

a8ci18n commented 3 days ago

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17012692

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @fushar for including a screenshot in the description! This is really helpful for our translators.

a8ci18n commented 19 hours ago

Translation for this Pull Request has now been finished.

Automattic / wp-calypso