Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Sites Dashboard: Remove all style overrides except those in `dataview-style.scss` #96662

Closed okmttdhr closed 7 hours ago

okmttdhr commented 8 hours ago

Related to https://github.com/Automattic/dotcom-forge/issues/9915

Proposed Changes

This PR removes all style overrides from the Dotcom Sites Dashboard except those in dataview-style.scss. (i.e., all the style overrides in Dotcom are now consolidated in dataview-style.scss!)

Removing hover (and focus) state overrides on thread: before after
Screenshot 2024-11-22 at 16 41 25 Screenshot 2024-11-22 at 16 41 17

Removing max-width in wider devices: pbxlJb-6A9-p2#comment-4019:

before after
Screenshot 2024-11-22 at 16 38 05 Screenshot 2024-11-22 at 16 38 47

Removing an override that does not make sense in Dotcom (originally copied from https://github.com/Automattic/wp-calypso/pull/87893)

Why are these changes being made?

pbxlJb-6DF-p2

Testing Instructions

Pre-merge Checklist

github-actions[bot] commented 8 hours ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125390
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125390&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125390&env=a8c-for-agencies
matticbot commented 8 hours ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/remove-dotcom-specific-overrides on your sandbox.

matticbot commented 8 hours ago

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

oandregal commented 7 hours ago

Nice one!