Update data files to CLDR v. 29 beta and related cleanup

Automattic / wp-cldr

Use CLDR localization data in WordPress

GNU General Public License v2.0

23 stars 6 forks source link

Update data files to CLDR v. 29 beta and related cleanup #80

Closed stuwest closed 8 years ago

stuwest commented 8 years ago

This PR implements CLDR29 (in beta now and out officially Wednesday March 16) and makes related underlying changes.

First commit updates the scripts for importing CLDR data to:

improve the mapping of WordPress locales to CLDR locales; update locale #unit tests which resolves #54.
include more CLDR JSON data items/files with time zone information and date/time formatting which are necessary to address #24, #41, #51.
exclude unnecessary files resolving #53.
reorganize the way files are stored which will make it easier to address #37.
make related changes to class and readmes.

Second commit is the 1200+ data files changes to add CLDR v29 data (via the first commit's new scripts) and remove CLDR v28 data.

Third commit demonstrates potential for new data with methods that return time zone city names, related tests, and demo on settings page. This resolves #15 and creates foundation to address #50.

stuwest commented 8 years ago

I did some squashing primarily to separate out the 1200+ data file changes into their own commit.

jblz commented 8 years ago

Nice :) I didn't review the data files commit (043406a), but most everything else looks good. I left a few line comments.

Please go ahead and merge the data files (or wait until the refresh comes out on Wednesday). It'll make this PR a lot more manageable.

stuwest commented 8 years ago

OK i added another commit with updates.

I don't want to wait for the final CLDR 29 to get this into the plugin review queue (that Wednesday release date might slip). So I merged the new files into master and did a rebase of this branch dropping the commit that included the files. Then I did a git push -f. I thought that was the right idea but not so much since it looks like the rebase caused your super helpful line comments and my erudite replies to be lost from this PR. Git-fu fail. I had the PR open in another tab so captured the below PDF with our back-and-forth.

LMK how it looks. Is this a case where I should squash all the PR commits into a single one before merging?

Update data files to CLDR v. 29 beta and related cleanup by stuwest · Pull Request #80 · Automattic:wp-cldr.pdf

jblz commented 8 years ago

This looks good to merge (once that text domain is put in).

I have a couple of translation-related suggestions, but I'll make a separate PR for simplicity sake. Great job!

stuwest commented 8 years ago

Squashed commits into 1. Lost the line comments again argh. There must be a way to preserve them.