Automattic / wp-e2e-tests

Automated end-to-end tests for WordPress.com
https://github.com/Automattic/wp-calypso
GNU General Public License v2.0
110 stars 20 forks source link

Media editor spec #1785

Closed JavonDavis closed 5 years ago

JavonDavis commented 5 years ago

Add spec for editing image from media in sidebar.

fixes #1769

JavonDavis commented 5 years ago

@JavonDavis We already have a function which does the same, without sleep. Can you re-use it?

@Stojdza I was looking to see if we had something like this already, thanks for pointing it out! It's no problem just bringing in the page object and using the function but in terms of reading the code, one might wonder why the editor page is here. What do you think is the best approach?

JavonDavis commented 5 years ago

Just use the Editor page? ( Which I'm perfectly fine with I'm just thinking it might be a bit misleading when reading this spec)

Went with this, let me know what you think? Another idea that popped up was maybe to make it static?

Stojdza commented 5 years ago

one might wonder why the editor page is here

Totally agree with this. Since the current solution was the fastest solution and it works well I'm also fine with it.

Use the media Page in the Editor Page(🤔this might make more sense, I think)

Yeah, this sounds like a good solution, at the end it's a media page, right? If it takes too much time, let's go with the current solution.

sirreal commented 5 years ago

Thanks!