search

Automattic / wp-e2e-tests

Automated end-to-end tests for WordPress.com
https://github.com/Automattic/wp-calypso
GNU General Public License v2.0
110 stars 25 forks source link

[WIP] Gutenberg iFrame Tests #1797

Closed bsessions85 closed 5 years ago

mmtr commented 5 years ago

@bsessions85 @Stojdza Work is nearing completion on implementing the iframe compromise and having the e2e tests ready to flip between Gutenlypso and Gutenframe is one of our remaining blockers. Do you have any update about this?

I'm happy to help, but I'm not sure what are the remaining steps.

Stojdza commented 5 years ago

Hey, @mmtr Let me check the status of this one.

Is it add/gutenberg-iframe-tests still active wp-calypso branch with the latest changes?

mmtr commented 5 years ago

Is it add/gutenberg-iframe-tests still active wp-calypso branch with the latest changes?

Yep! I rebased it with master a few hours ago.

Stojdza commented 5 years ago

@mmtr Tests are ready. All of them are passing against wp-calypso branch add/gutenberg-iframe-tests

mmtr commented 5 years ago

@bsessions85 @Stojdza do you have any idea why the e2e tests on https://github.com/Automattic/wp-calypso/pull/30529 don't pass? That PR is for merging the Calypso branch add/gutenberg-iframe-tests so we're assuming they will run the e2e tests against this branch, right?

mmtr commented 5 years ago

I checked locally the 6 failing test and they all passed, so I'd say we can go ahead and merge this.

Stojdza commented 5 years ago

@mmtr I've merged latest changes from e2e master branch and run tests once again, on this PR and on wp-calypso PR, and both run passed.

Feel free to merge this PR together with https://github.com/Automattic/wp-calypso/pull/30529

rodrigoi commented 5 years ago

🚀 🌕