search

Automattic / wp-e2e-tests

Automated end-to-end tests for WordPress.com
https://github.com/Automattic/wp-calypso
GNU General Public License v2.0
110 stars 25 forks source link

Domains: No more privacy #1813

Closed aidvu closed 5 years ago

aidvu commented 5 years ago

Lower the count of products in cart.

Stojdza commented 5 years ago

@aidvu Test is failing because there are still 2 products in the cart. Does one of these two should miss?

aidvu commented 5 years ago

@Stojdza this is one of those cases where we need the master PR to land, for this to work. https://github.com/Automattic/wp-calypso/pull/30948

Stojdza commented 5 years ago

Oh, ok. Didn't know about that PR.

You could name this branch the same as wp-calypso branch so tests from this branch could run against wp-calypso PR.

aidvu commented 5 years ago

Oooooh, what you're saying is if the branch names are the same, it won't run on master but on that branch?

Stojdza commented 5 years ago

Exactly :) We've introduced that a few months ago in this PR

From FG page: Sometimes you need to update the e2e test to match the changes introduced in your calypso PR. In that case, simply creating a branch with the same branch name as the calypso PR on the e2e test repo, and our CI setup will pair them automatically.

aidvu commented 5 years ago

In favor of https://github.com/Automattic/wp-e2e-tests/pull/1814.