Automattic / wp-openid-connect-server

Use OpenID Connect to log in to other webservices using your own WordPress
https://wordpress.org/plugins/openid-connect-server/
GNU General Public License v2.0
23 stars 5 forks source link

Filter `site_status_tests` #107

Open valentin-anamorphik opened 10 months ago

valentin-anamorphik commented 10 months ago

Hi,

We have two errors in the "Site Health" section of WP.

The public key constant OIDC_PUBLIC_KEY is malformed.
The private key constant OIDC_PRIVATE_KEY is malformed.

Because,

var_dump(substr( OIDC_PUBLIC_KEY, - strlen( '-----END PUBLIC KEY-----' )));

// return string(24) "----END PUBLIC KEY----- ";

My public key ends with "-----END PUBLIC KEY-----"

It's the same problem with the private key.

var_dump(substr( OIDC_PRIVATE_KEY, - strlen( '-----END RSA PRIVATE KEY-----' )));
// return string(29) "----END RSA PRIVATE KEY----- "

Thanks.

ashfame commented 9 months ago

@valentin-anamorphik Hi, Can you test if this is still a problem with latest release 1.3.3? If so, can you supply how your key headers look like. Some improvements in detection was done in #105 so should be good now.