search

Automattic / wp-prettier

Prettier is an opinionated JavaScript formatter.
https://prettier.github.io/prettier/
MIT License
51 stars 1 forks source link

Integrate with prettierx? #17

Open iandunn opened 4 years ago

iandunn commented 4 years ago

Prettierx is a prettier fork that aims to be less opinionated, and they've cherry-picked --paren-spacing.

Would it make more sense to collaborate on that project, rather than maintaining this one seperately?

brodycj commented 4 years ago

I have pulled in the tests and src updates from the wp-prettier-2.0.5 branch and merged updates from Prettier 2.0.0 .. 2.0.5 into prettierx. I have also gone through to test almost every change taken from wp-prettier, discovered some minor issues, and resolved a limited number of them.

It has been a pretty major effort to incorporate the changes, add the test coverage, and deal with the resulting merge conflicts from Prettier master, but I think the --paren-spacing feature is a really nice case of flexibility that prettierx offers over Prettier itself.

I leave it up to your team to decide whether to use prettierx, raise issues if needed, and contribute as desired, or continue with your own fork.