Autonomous-Motorsports-Purdue / AMP_ASSv2

Reassembled, simpler, without move_base and loop closure issues

5 stars 1 forks source link

AMP-CLIv0.1 #32

Closed alanssitis closed 2 years ago

alanssitis commented 2 years ago

What is a quick description of the change?

Implementation of AMP-CLI. Should be considered as a beta-release for testing.

Is this fixing an issue?

Close #19

Were any issues created as a result of this change?

30 and #31

Are there more details that are relevant?

Check lists (check x in [ ] of list items)

For each of these items, please refer to the software style guide

[x] Coding style

Any additional comments?

None

alanssitis commented 2 years ago

@zghera @Reschivon Could any of you review this PR? I will need some of these docker images in order to work on the CI pipeline for building.

alanssitis commented 2 years ago

Try running it with the build flag!

zghera commented 2 years ago

Try running it with the build flag!

Ahhhhh, it seems to be building now! I probably should have ran amp-cli devel --help, silly me. Is there any way you could catch that exception in your code and advise the user to run with --help or --build in case someone forgets like me?

Reschivon commented 2 years ago

Looks good to me!