Autonomous-Motorsports-Purdue / AMP_ASSv2

Reassembled, simpler, without move_base and loop closure issues
5 stars 1 forks source link

Implement Serial Communication for ASSv2 #58

Closed alanssitis closed 1 year ago

alanssitis commented 1 year ago

Short description

Use rosserial to implement serial communications.

amp-cli felt very unnecessary and cluttered the code base. It's deletion will hopefully make development easier. Updated README to recommend colcon as an alternative build system and updated .gitignore to account for this.

Issue closed (if applicable)

7 (Bypassed issue by replacement)

New issues created by PR

59

Relevant details

Create new ros_lib library to be included in Teensy MC source code.

colcon feels better and more polished than catkin. They can both coexist so it should not be an issue to support both. In fact, colcon is more robust and forces the developer to update CMakeList.txt religiously and make sure python files and other scripts include a shebang.

Additional details

Previous serial communications library was too complex and caused a multitude of reasons for the team, thus we dropped it from the stack to slim down the whole stack.

Resources

Task checklist

alanssitis commented 1 year ago

I can't seem to figure out the automatic building, it will need to be done manually...

alanssitis commented 1 year ago

I can't seem to figure out the automatic building, it will need to be done manually...

Got it working :)

alanssitis commented 1 year ago

@Reschivon I got it working lol.

alanssitis commented 1 year ago

We are moving from this repo