search

Autonomous-Racing-PG / ar-tu-do

ROS & Gazebo project for 1/10th scale self-driving race cars
88 stars 36 forks source link

Add dms parameters to launch files #199

Closed Nils-Jung closed 5 years ago

Nils-Jung commented 5 years ago

PR #197 added some parameters for the dead man switch but forgot to include them in the main launch files. This meant that those parameters could not be set. This PR fixes this.

marian42 commented 5 years ago

Why is this needed? There are already default values set in car_control.launch. Why do these need to be copied to the main launch file? It doesn't look like this has any effect.

Nils-Jung commented 5 years ago

Why is this needed? There are already default values set in car_control.launch. Why do these need to be copied to the main launch file? It doesn't look like this has any effect.

If a launch file includes another launch file, arguments have to be passed down for them to work. Please try the command roslaunch launch/gazebo_car-autonomous.launch dms_enabled:=false in both this branch and the current master branch to see the difference. Further reference: https://wiki.ros.org/roslaunch/XML/arg#Introduction

marian42 commented 5 years ago

Ok, I understand the argument is needed to expose a command line parameter. In that case, would it make sense to leave out the dms_check_rate and dms_expiration parameters? I can't imagine a case where these would be set via comand line.

marian42 commented 5 years ago

I refactored the dms_enable parameter in PR #201 so this may no longer be needed.

StefanJVA commented 5 years ago

I refactored the dms_enable parameter in PR #201 so this may no longer be needed.

So can we delete this PR then?

Nils-Jung commented 5 years ago

This branch seems to be obsolete now.