search

AutonomyLab / bebop_autonomy

ROS driver for Parrot Bebop Drones 1.0 & 2.0
http://wiki.ros.org/bebop_autonomy
BSD 3-Clause "New" or "Revised" License
152 stars 121 forks source link

Add support for SDK 3.12.6 #120

Closed thomas-bamford closed 7 years ago

thomas-bamford commented 7 years ago

Warning not tested on vehicles. Compiles with parrot-arsdk on branch sdk-3-12

thomas-bamford commented 7 years ago

Have to run tests on vehicles prior to merging branch to ensure all changes are safe.

thomas-bamford commented 7 years ago

Failed build tests due to sdk-3-12 dependency

mani-monaj commented 7 years ago

Thanks so much @thomas-bamford for leading this release. The CI failure is expected as you mentioned. I suggest to follow the following steps:

  1. Run tests (preferably bebop-in-the-loop tests) using this branch of bebop-autonomy compiled against SDK 3.12.6 (https://github.com/AutonomyLab/parrot_arsdk/pull/5)
  2. Merge parrot_arsdk 3.12.6 's PR (https://github.com/AutonomyLab/parrot_arsdk/pull/5)
  3. Release parrot_arsdk 3.12.6 as binary to ROS
  4. When the new binary is available (synced), merge this branch
thomas-bamford commented 7 years ago

You're welcome. I will be able to run the tests on a Bebop 2 this Friday. @Voidminded do you have access to a Bebop 1 to run the tests?

thomas-bamford commented 7 years ago

Tests passed using this branch of bebop-autonomy compiled against SDK 3.12.6 on Bebop 2 with software version 4.0.6.

Terminal output is found in 'sdk-3-12-test.txt.' The original test failed for the BebopInTheLoopTest.VisionTest because of camera info image size not matching video feed image size. To remedy this I have committed a modified bebop2 camera calibration for the vehicle I ran the tests on.

sdk-3-12-test.txt

thomas-bamford commented 7 years ago

As a temporary fix to the parrot_arsdk debian package build failing for sdk 3.12.6 on 64bit ubuntu xenial, I suggest (and have added documentation to the installation) to install the package by source.

thomas-bamford commented 7 years ago

PR for patch to fix build issues in parrot_arsdk has been submitted.

thomas-bamford commented 7 years ago

semaphoreci fails at the sudo apt-get update -q step which seems unrelated to the build