search

AutonomyLab / libcreate

C++ library for interfacing with the iRobot Create 1 and 2.
BSD 3-Clause "New" or "Revised" License
47 stars 76 forks source link

Enable to run on ROS Melodic #38

Closed youtalk closed 5 years ago

youtalk commented 5 years ago

Solved https://github.com/AutonomyLab/create_autonomy/issues/54

When I used this package on Ubuntu 18.04 and ROS Melodic, I had the same problem above.

roslaunch ca_driver create_2.launch
...
[ INFO] [1549365785.956563724]: [CREATE] "CREATE_2" selected
[create::Serial] failed to receive data from Create. Check if robot is powered!
[create::Create] retrying to establish serial connection...
[create::Serial] serial error - Operation canceled
[create::Serial] failed to receive data from Create. Check if robot is powered!
[create::Create] retrying to establish serial connection...
[create::Serial] serial error - Operation canceled
...

This PR solves it based on https://github.com/AutonomyLab/create_autonomy/issues/54#issuecomment-450024493

lopsided98 commented 5 years ago

I don't currently have ROS setup on my Create, so I can't test this. I might get it running again in the next few weeks, but I'm not sure I'll have time.

youtalk commented 5 years ago

@lopsided98 I'm sorry but https://github.com/AutonomyLab/libcreate/commit/d2cc4b9552156de2a8d2229e4fe778af9ff8ca86 was my mistake to push. I reverted the commit.

jacobperron commented 5 years ago

@youtalk Thanks for the patch. I'll try to set aside some time to test it this week and I can work on a release for Melodic.

komeihasegawa commented 5 years ago

This worked fine with my Ubuntu18.04, ROS Melodic, and Create1.