Describe the bug
result.update_uncertainty() doesn't actually update the uncertainties for two reasons:
There's an error in the code itself in ap.lm.fit.update_uncertainty where vector_set_uncertainty is set to the value rather than being called.
vector_set_uncertainty doesn't clearly work at processing uncertainties that can be scalars or vectors. center being the relevant quantity here.
I've started a branch that adds a test that compares the uncertainties from the sersic galaxy fit test and making sure the fit model gets updated with them.
To Reproduce
git checkout u/wmwv/test-parameter-uncertainty-set
cd astrophot
pytest tests/test_fit.py -k test_sersic_fit_lm
Describe the bug result.update_uncertainty() doesn't actually update the uncertainties for two reasons:
ap.lm.fit.update_uncertainty
where vector_set_uncertainty is set to the value rather than being called.vector_set_uncertainty
doesn't clearly work at processing uncertainties that can be scalars or vectors.center
being the relevant quantity here.I've started a branch that adds a test that compares the uncertainties from the sersic galaxy fit test and making sure the fit model gets updated with them.
To Reproduce
git checkout u/wmwv/test-parameter-uncertainty-set cd astrophot pytest tests/test_fit.py -k test_sersic_fit_lm