search

Auxilor / Boosters

Boosters plugin for the latest minecraft version
GNU General Public License v3.0
27 stars 23 forks source link

[BUG] New placeholder name doesn't display name #21

Open adelando opened 2 years ago

adelando commented 2 years ago

Hello,

With the new placeholder %boosters_< name >_name% it does not display any title but seconds and other placeholders do.

for example, this is my config using TAB for bossbars...

booster_bonushealththree: style: "PROGRESS" color: "YELLOW" progress: "100" text: "#e7a9f5 #5ae0c8Active: #e7a9f5 %boosters_bonushealththree_name% &5&l| #5ae0c8Timer: #e7a9f5 %boosters_bonushealththree_seconds_remaining%" display-condition: '%boosters_bonushealththree_seconds_remaining%>1'

"bonushealththree" being my booster ID

And this is how it displays. 2022-05-12_16 01 11

WillFP commented 2 years ago

I can't recreate that - it definitely works for me

adelando commented 2 years ago

I’ve seen this not working for a few people in the boosters discord channel, all other new placeholders seem to work fine just the name placeholder. I’ve also tried shortening the id name and still the same.

natereprogle commented 2 years ago

Yeah, same for me. All the placeholders except the name placeholder work. Is there not a way to implement a placeholder to display any active booster, like a wildcard? That'd be really nice

natereprogle commented 2 years ago

Actually, pretty sure I see what's going on. There isn't a name placeholder being registered by this plugin. https://github.com/Auxilor/Boosters/blob/master/eco-core/core-plugin/src/main/kotlin/com/willfp/boosters/boosters/Booster.kt

@WillFP I created a pull request, but I'm not familiar with Kotlin, so hopefully this is the correct syntax https://github.com/Auxilor/Boosters/pull/23