search

Auxilor / EcoArmor

Custom armor sets plugin for the latest minecraft version
GNU General Public License v3.0
31 stars 27 forks source link

Bonus Health effect not functional. #12

Closed ghost closed 2 years ago

ghost commented 2 years ago

Describe the bug The effect Bonus Health doesn't work properly

To Reproduce Steps to reproduce the behavior:

  1. Give yourself any armor set that has bonus_health
  2. set the health to whatever number you want, I tried tons of numbers between 10 & 250
  3. Reload the plugin, and equip the armor.
  4. Notice that you don't get any extra hearts.

Expected behavior Well, obviously get more hearts based on what's written in the configuration

Screenshots N/A

Server Information (please complete the following information):

Additional context N/A

ltjessem commented 2 years ago

My understanding is that the the hearts are adjusted so max health is always displayed as 10 hearts. Check the attribute minecraft:generic.max_health when you equip a set or:

  1. Give yourself an armor set with +20 bonus health
  2. Equip the armor, your health should be displayed as 5/10 hearts (because max health has doubled)
  3. /heal or wait to regenerate health
  4. Unequip armor , health should be displayed as 20 hearts