search

Auxilor / EcoArmor

Custom armor sets plugin for the latest minecraft version
GNU General Public License v3.0
31 stars 27 forks source link

add_stat effect improperly calculated for per-piece armor effects #26

Open Opalinium opened 2 years ago

Opalinium commented 2 years ago

Describe the bug add_stat is improperly counted for pie-piece armor effects, seemingly based on stat values after bonuses, meaning the order in which armor is put on will completely change the final value

To Reproduce Steps to reproduce the behavior:

  1. Create an armor set with add_stat (defense) as per-piece effects
  2. Equip the armor set in varying order
  3. Note the differences of stats applied based on the order you equip the individual armor pieces

Expected behavior The add_stat effect should be additive comparatively to the base stat values, and should take into account multiple armor pieces in the event that per-piece effects are used

Screenshots NVIDIA_Share_v250tQYHoN

Server Information (please complete the following information):

jezry commented 2 years ago

yes pls fix this

OmegaWulf commented 2 years ago

Same problem with bonus_health

The order of putting on the armor changes the amount granted. For me, adding the chestplate on last gives 20 more HP than it's supposed to.

Full set is supposed to give +100 hp but if the chestplate is put on last, the player gains +120.

For info: I'm only using individual armor bonuses and have no set bonus for HP.