0ft3n
commented
2 years ago I think there's an issue with unintended hiding of enchants in this section of code (66d06d7). I've had a number of players lose the enchantments on their items, which we later realized was just hiding of the enchantments. Both the hide enchants and ecoenchant-lore options become set, and enchants stay hidden even when the hide enchants flag is unset manually (I think it stays hidden because I cannot unset ecoenchant-lore).
We noticed the issue after messing around with a drugs plugin that gives items that have hidden enchant/potion effects. We use the items and then the potion effect becomes active, and the item is consumed. I assume this is somehow causing eco to apply the hide flag to unrelated items.
Server Information (please complete the following information):
- Version: git-Purpur-1788 (MC: 1.19.2)* eco version 6.41.1 EcoEnchants version 9.0.0-b30
Additional context This might be related to #299
The code you are reffering to is checking if item had hide enchants flag before the display so it's not an issue, it's how it works
MillionthOdin16
I think there's an issue with unintended hiding of enchants in this section of code (66d06d7a4a36109b6de232f55709ef5f35f72ecc). I've had a number of players lose the enchantments on their items, which we later realized was just hiding of the enchantments. Both the hide enchants and ecoenchant-lore options become set, and enchants stay hidden even when the hide enchants flag is unset manually (I think it stays hidden because I cannot unset ecoenchant-lore).
We noticed the issue after messing around with a drugs plugin that gives items that have hidden enchant/potion effects. We use the items and then the potion effect becomes active, and the item is consumed. I assume this is somehow causing eco to apply the hide flag to unrelated items.
Server Information (please complete the following information):
Additional context This might be related to #299