Auxilor / EcoEnchants

Custom Enchantments Plugin for the latest minecraft version
GNU General Public License v3.0
262 stars 160 forks source link

Sculk block bug - Eco Enchant causing it #320

Open AccioAce opened 1 year ago

AccioAce commented 1 year ago

Describe the bug There is a bug issue that had never been resolved in the old and new version of eco enchant as I was testing it. It somehow prevents sculk blocks from dropping EXP. I have did some testing and is directly coming from eco enchant. I had made a github post a long a while ago and it has not even been resolved now either. so please do fix it.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior Breaking sculk block should give EXP.

Screenshots This need to be fixed -> https://gyazo.com/0ee1bf246c5f8d1efca6d5bccae31cad Here is what suppose to look like without eco/ecoenchant https://gyazo.com/034073aaaefeed36e980eba99bf77817

Server Information (please complete the following information):

Additional context

nhanledev commented 1 year ago

+1 for this.

nhanledev commented 1 year ago

This bug is caused by the EnchantmentTelekinesis's BlockBreakEvent (https://github.com/Auxilor/EcoEnchants/blob/854ae5d69d3dca6cab227e71944c3cf62792850a/eco-core/core-plugin/src/main/kotlin/com/willfp/ecoenchants/enchants/impl/EnchantmentTelekinesis.kt#L61) does not have hasEnchantActive check.