Auxilor / EcoItems

Custom items plugin for the latest spigot version
GNU General Public License v3.0
50 stars 27 forks source link

add_stat stat boosts updating weirdly #24

Closed PrimalPower closed 2 years ago

PrimalPower commented 2 years ago

If you switch from an item that gives an aurelium skills stat boost to another item that gives an aurelium skills stat boost directly it will not update the boost. This problem will not happen if you hold a item that doesn't give a stat boost in between (i don't know if this will also happen with ecoskills. I am also unsure if it is with all permanent effects or just add_stat)

To Reproduce Steps to reproduce the behavior:

  1. Install aurelium skills
  2. Create an item that grants 40 toughness using add_star (can be any stat and any number)
  3. Create an item that grants 40 strength using add_star (can be any stat and any number)
  4. If you put them next to each other in hotbar and start by holding the 40 toughness one, you will get 40 toughness. If you switch directly to the 40 strength one, it will keep the 40 toughness and not give 40 strength (and vice versa).

Expected behavior When I switch I will lose 40 toughness and gain the 40 strength

Edit When switching directly between stat boosting items it can act completely unpredictably if they both share a stat and one of the items gives an extra stat

Server Information (please complete the following information):

WillFP commented 2 years ago

I think this is down to how AureliumSkills handles things, because I do the same with EcoSkills and it works fine

PrimalPower commented 2 years ago

I think this is down to how AureliumSkills handles things, because I do the same with EcoSkills and it works fine

I found that it was because Aurelium Skills commands blocks the modifier if a modifier with same name already exists instead of overriding