search

Auxilor / eco

Spigot development library, built for the latest version.
MIT License
155 stars 51 forks source link

Lag/Crash exploit #357

Open SengyEU opened 3 months ago

SengyEU commented 3 months ago

Describe the bug Clicking on some gui buttons causes the server to lag.

To Reproduce Steps to reproduce the behavior:

  1. Open EcoJobs gui (It works in another plugins too, e.g. EcoSkills as some reported on discord)
  2. Join 3/3 jobs (or whatever your limit is)
  3. Start spamming joining another job with autoclicker.

Expected behavior It should cancel the action completely and don't do anything. Maybe add a cooldown to it?

Screenshots Here is a video: https://media.discordapp.net/attachments/1019933037829574706/1241853823019122698/Minecraft__1.20.4_-_Multiplayer_3rd-party_Server_2024-05-19_22-42-12.mp4?ex=6650fbff&is=664faa7f&hm=438758f38260f24d5cbaa9d791f78c4db041bff615ce7839e389a4fe679da2b6&

Server Information (please complete the following information):

Additional context It only applies to items, which don't take you to another gui and have action on them (e.g. trying to join a job, when you have 3/3)

WillFP commented 1 month ago

Not directly an eco bug, please open an issue on the discord however I'll leave this open in case a general patch can be made.

(note to self, if gui caching is more plugin-specific then it might be better to add a new builder method in ecomponent)