search

AvaProtocol / oak.js

Javascript dev-utils library to access OAK Network APIs, leveraging typing decoration of polkadot.js library.
Apache License 2.0
2 stars 0 forks source link

Is types package really needed? #31

Closed chrisli30 closed 1 week ago

chrisli30 commented 1 year ago

api-augment package has the same definitions as the ones in types. The code seems to be duplicated. https://github.com/OAK-Foundation/oak.js/blob/78530a36321a81d1723da8a5a792d6e04e40b531/packages/api-augment/src/interfaces/automationTime/definitions.ts

Usage https://github.com/OAK-Foundation/xcm-demo/blob/05d0897239c8e0fda2870467707878c9e44e23a5/src/common/turingHelper.js#L3

Solution

  1. Check if the same rpc, types can be exported from the api-augment library.
  2. Check if the npm run generate script can auto-update the definitions in the api-augment.
github-actions[bot] commented 1 month ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 2 weeks ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 week ago

This issue was closed because it has been stalled for 7 days with no activity.