Remove Type ignore from DataNode.storageType() method

[jrobinAV]

The storageType method must return a str and not an Optional[str]. This is incompatible with the current implementation of the _class_map method

[ashutuptiwari]

I am assuming you're referring to this method in the file src/taipy/core/data/data_node.py. Can you explain the changes that are needed and assign this issue to me @jrobinAV

[trgiangdo]

If you remove the # type: ignore, mypy will complain that:

Incompatible return value type (got "Type[NotImplementedError]", expected "str")

The purpose of this issue is to safely remove the # type: ignore and still follow mypy style guideline.

[ashutuptiwari]

Alright I'll get started @trgiangdo . Please assign this issue to me @jrobinAV

[ashutuptiwari]

If you remove the # type: ignore, mypy will complain that:

Incompatible return value type (got "Type[NotImplementedError]", expected "str")

The purpose of this issue is to safely remove the # type: ignore and still follow mypy style guideline.

What command is leading to this error log? @trgiangdo

[trgiangdo]

You can try to remove the # type: ignore and run this command on the terminal:

mypy --ignore-missing-imports --implicit-optional .

[ashutuptiwari]

Thanks!

[ashutuptiwari]

i got this error 2 times , but not the one that you mentioned

 error: No overload variant of "asdict" matches argument type "_BaseModel"  [call-overload]

@trgiangdo

[trgiangdo]

The full error message that you are looking for:

src/taipy/core/data/data_node.py:314: error: Incompatible return value type (got "Type[NotImplementedError]", expected "str")  [return-value]

If it's not showing up, maybe we are missing something.

[ashutuptiwari]

Yeah that one isn't there @trgiangdo

[ashutuptiwari]

@trgiangdo ?

[trgiangdo]

Can you show me:

• The Python version
• The mypy version
• The screenshot of the src/taipy/core/data/data_node.py file at line 311-314

[ashutuptiwari]

Sure, what command should i use for python @trgiangdo ? The mypy version is giving the same result as before Here is the ss of the code you asked for

[trgiangdo]

Can you try to remove the # type: ignore from line 314? Then the error I mentioned should show up.

[ashutuptiwari]

Both these solution seem to resolve this error @trgiangdo

1. 

2. 

[ashutuptiwari]

@trgiangdo

[trgiangdo]

Sorry for the late response, I was away for the weekend.

About your fix, it's contradictory with the purpose of the storage_type() method. It should always return the NotImplemented exception to avoid the user from using the _DataNode class directly, or a child class without the storage type would raise an error.

Please find another work-around

[ashutuptiwari]

This seems to work as well @trgiangdo

[ashutuptiwari]

Hacktoberfest will be ending tomorrow so it will be really helpful if we could close this issue before then @trgiangdo . Please review this solution

[ashutuptiwari]

Hey, i think there has been some mistake because this repository is shown as not participating in hacktoberfest 2023. Please look into it. @trgiangdo @jrobinAV @FlorianJacta

[ashutuptiwari]

Please confirm @trgiangdo

[FlorianJacta]

@ashutuptiwari The warning should go away now. Can you try again?

[ashutuptiwari]

Yes it did @FlorianJacta . Thanks a bunch!

[ashutuptiwari]

I guess this issue can be closed?

[trgiangdo]

We will review it and close done issue on every sprint. The merged PR should be sufficient for the hacktoberfest, no?

[ashutuptiwari]

Oh yes it is. I was just curious.

[ashutuptiwari]

Hi guys, I was wondering if i would recieve some sticker packs or some swag @FabienLelaquais @jrobinAV @FlorianJacta @marisogo

[marisogo]

Hi @ashutuptiwari, can you shoot me an email at: marine.gosselin@taipy.com? So we can organize sending you the swag :)