search

Avaiga / taipy-core

A Python library to build powerful and customized data-driven back-end applications.
Apache License 2.0
38 stars 17 forks source link

feature/#671 added api for job deletable #699

Closed toan-quach closed 1 year ago

toan-quach commented 1 year ago

671

github-actions[bot] commented 1 year ago

☂️ Python Cov

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7346 7060 96% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/taipy/core/job/_job_manager.py 100% 🟢
src/taipy/core/job/job.py 99% 🟢
src/taipy/core/taipy.py 87% 🟢
TOTAL 95% 🟢

updated for commit: e7232e5 by action🐍

jrobinAV commented 1 year ago

The PR looks good.

I only have a few minor comments:

  1. Should we expose the is_deletable() method at Job level as well? Just like scenario, so the user can do something like job.is_deletable().
  2. Should the test_is_deletable() be duplicated to the test_job_manager_with_sql_repo.py as well?

Yes, good ideas.

toan-quach commented 1 year ago

@trgiangdo you're right! lemme add that as well!