search

Avaiga / taipy-core

A Python library to build powerful and customized data-driven back-end applications.
Apache License 2.0
38 stars 17 forks source link

remove type:ignore from DataNode.storageType() method #417 #809

Closed ashutuptiwari closed 1 year ago

ashutuptiwari commented 1 year ago

Instead of 

return NotImplementedError

I did

raise NotImplementedError

This is for issue #417

ashutuptiwari commented 1 year ago

can i get some help with these build errors @trgiangdo ?

trgiangdo commented 1 year ago

Please be patient with me. I'm on it

ashutuptiwari commented 1 year ago

Yes of course , thanks for your help

ashutuptiwari commented 1 year ago

That's a great news! It was fun working on this issue and you @trgiangdo have been really helpful. Also , it would be really great if this PR could be merged before tomorrow so it could count in my hacktoberfest contributions. Cheers.

trgiangdo commented 1 year ago

We will merge it after PR #810 is merged. It should be done by today

ashutuptiwari commented 1 year ago

Yay