search

Avaiga / taipy-core

A Python library to build powerful and customized data-driven back-end applications.
Apache License 2.0
38 stars 17 forks source link

bug/ fixed import path broke enterprise repo import #830

Closed toan-quach closed 11 months ago

toan-quach commented 11 months ago

Issue

The tests in enterprise repo are failing due to unable to import from src.taipy.core.notification.event import _make_event. https://github.com/Avaiga/taipy-enterprise/actions/runs/6958399104/job/18933316373?pr=267

Change

Due to the structure of our dependencies, relative import is preferred as absolute import doesn't work. This PR provides a simple fix to the issue by replacing absolute import with relative import

toan-quach commented 11 months ago

@gmarabout no worry!! I'll merge it once the tests passed :D

github-actions[bot] commented 11 months ago

☂️ Python Cov

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8716 8257 95% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/taipy/core/sequence/_sequence_manager.py 94% 🟢
TOTAL 94% 🟢

updated for commit: d93917d by action🐍