Avaiga / taipy-core

A Python library to build powerful and customized data-driven back-end applications.

Apache License 2.0

38 stars 17 forks source link

Event Creation: Add version and make sure we don't call autoreload attributes #834

Closed gmarabout closed 11 months ago

gmarabout commented 11 months ago

Goal

Make sure all events are created without accessing fields that would "auto reload" the entity (and thus could create performance issues)
Add version in metadata of entities

Changed

Data_node: add _version
Job: Use internal fields to by-pass autoreload
Scenario: Use internal fields to by-pass autoreload
Submission: small refactoring
Cycle: no change, there is no version for it?

gmarabout commented 11 months ago

looks good to me! but can you quickly explain why we wouldn't want to use auto reload here? Is the consistency of the value already guaranteed?

@toan-quach I actually don't want autoreload to happen! This function must have the least performance penalty possible 🚀

github-actions[bot] commented 11 months ago

☂️ Python Cov

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status

8721 8261 95% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status

src/taipy/core/data/data_node.py 99% 🟢

src/taipy/core/job/job.py 98% 🟢

src/taipy/core/scenario/scenario.py 94% 🟢

src/taipy/core/submission/submission.py 95% 🟢

TOTAL 96% 🟢

updated for commit: 8b94193 by action🐍

File	Coverage	Status
src/taipy/core/data/data_node.py	99%	🟢
src/taipy/core/job/job.py	98%	🟢
src/taipy/core/scenario/scenario.py	94%	🟢
src/taipy/core/submission/submission.py	95%	🟢
TOTAL	96%	🟢