search

Avaiga / taipy

Turns Data and AI algorithms into production-ready web applications in no time.
https://www.taipy.io
Apache License 2.0
14.9k stars 1.82k forks source link

Pipenv is too slow. Shift to a faster package manager. #1149

Open anunayasri opened 6 months ago

anunayasri commented 6 months ago

Description I want to contribute to taipy codebase and am setting up the code in my local. pipenv install took minutes to setup the dependencies. I suggest to shift to a faster dependency manager like pdm. pdm can import Pipfile from the project and generate a pyproject.toml file that it uses. I think shifting to pdm is easier.

Files to be added to the repo:

.pdm-python will be generated and should not be committed. It is to be added to .gitignore.

Acceptance Criteria

anunayasri commented 6 months ago

I can pick it up if maintainers are fine with shifting to pdm.

FlorianJacta commented 6 months ago

We are reviewing your request internally.

Prathamesh010 commented 3 weeks ago

Please assign me this issue. Thank you @FlorianJacta.

Also, Is this reviewed internally as you mentioned above?

anunayasri commented 3 weeks ago

I think it was discussed in another thread that taipy repo will be on Pipenv. As of Oct 3, 2024, the pipenv install is still super slow on my laptop. It gets stuck in the 'Locking' phase. pdm took 10min to install the the deps in a fresh virtual env.

I think we can close this issue for now. I will try to write the steps of using pdm in a gist or discussion and will share. Hopefully, it will the contributors who are unhappy with pipenv.

AlexandreSajus commented 3 weeks ago

Assigned

Prathamesh010 commented 3 weeks ago

@anunayasri Can you please link the thread? or @FredLL-Avaiga and @FabienLelaquais Can you please confirm if this is still relevant or we can close this issue?

quest-bot[bot] commented 3 weeks ago

New Quest! image New Quest!

A new Quest has been launched in @Avaiga’s repo. Merge a PR that solves this issue to loot the Quest and earn your reward.

Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #1149 to link your PR to this Quest.

Questions? Check out the docs.

anunayasri commented 2 weeks ago

The relevant thread: https://github.com/Avaiga/taipy/issues/1151#issuecomment-2388313722 @Prathamesh010

@AlexandreSajus I think this issue can be closed.

anunayasri commented 2 weeks ago

I have used to use pdm and uv for dependency management in my local. I have listed the steps here: https://github.com/Avaiga/taipy/discussions/1955

Sahiltripathy005 commented 2 weeks ago

I’m eager to contribute to this issue

FlorianJacta commented 2 weeks ago

We'll review the state of this issue with @jrobinAV and @FabienLelaquais

anunayasri commented 2 weeks ago

@FlorianJacta FYI. There is a parallel discussion that happened in https://github.com/Avaiga/taipy/issues/1151. @FabienLelaquais has few comments there. I have partially solved the issue for myself and listed the steps in https://github.com/Avaiga/taipy/discussions/1955. I would love to solve it permanently. My related comment shifting regarding shifting to uv https://github.com/Avaiga/taipy/issues/1151#issuecomment-2397638508

github-actions[bot] commented 4 days ago

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

muhammedsafuvan commented 2 days ago

@FlorianJacta is this resolved? If not can you assign it to me?