Open gbritoda opened 3 months ago
Please assign this to me
Hello @pravintargaryen,
Our core maintainer team still needs to review this issue. We are still determining if or how we want to include it in the taipy library. Please give us some time to review the issue before engaging it. This should not be long.
Meanwhile, I invite you to look at the issues with the labels "good first issue" or "Help wanted". These tickets have been reviewed, approved and are opened for a contribution.
thank you.
Hello @pravintargaryen,
The issue has been reviewed. Thank you for volunteering. Go ahead, give it a try. This is not so easy, so make sure you get in touch with the appropriate maintainers: @FredLL-Avaiga @FabienLelaquais @dinhlongviolin1 @namnguyen20999
Thank you @jrobinAV and @pravintargaryen
The real difficulty is going to be to keep the control's property API backward compatible. We certainly can help designing this.
Hello @pravintargaryen,
Any news on the issue?
Cheers,
Hi @jrobinAV,
Apologies for being behind schedule
Working on new icons from Material UI for the frontend status component. Have to test it though.
\taipy\frontend\taipy-gui\src\components\Taipy\Status.tsx \taipy\frontend\taipy-gui\src\components\Taipy\StatusList.tsx
No pb. Take the time you need, of course.
Hi @jrobinAV,
Apologies for being behind schedule
Working on new icons from Material UI for the frontend status component. Have to test it though.
\taipy\frontend\taipy-gui\src\components\Taipy\Status.tsx \taipy\frontend\taipy-gui\src\components\Taipy\StatusList.tsx
Are the new icons "in line" with the icons we already use ? I thought you'd design a way to provide external icons ie allows the developer to add icons without changing the taipy-gui bundle.
This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.
Approaching PR
Thank you @pravintargaryen. The maintainers team is reviewing your PR.
This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.
Made a glitch from my end https://github.com/Avaiga/taipy/pull/1413. Will resend the PR.
Sent a pull request with updated branch details https://github.com/Avaiga/taipy/pull/1580
Description For the Status GUI control, instead of showing E, S, I and W, it would be nice to have a way to put icons in it instead.
Acceptance Criteria