Improve filter UX in Data Node/Scenario Selector

FlorianJacta commented 5 months ago

Description

The UX of creating filters could be better in the Data Node/Scenario selector. It would be better to propose something like this:

when the filter is on a boolean to have a switch: this simplifies the process of creating a boolean filter immensely,
when the filter is on a date to have date/time picker.

Providing a default "action" for each filter would enhance the filter UX. For example, the tags filter could have as a default action: "contains". Right now, you need a lot of clicks to get the filter in place.

Code of Conduct

[X] I have checked the existing issues.
[ ] I am willing to work on this issue (optional)

ovindu-a commented 1 month ago

Hi, can I work on this?

jrobinAV commented 1 month ago

Sure! @ovindu-a

Thank you for your contribution.

ovindu-a commented 1 month ago

Hi @jrobinAV, quick question. Could you tell me if there is a way I can test the changes once I make them?

jrobinAV commented 1 month ago

Hi @ovindu-a ,

I believe @namnguyen20999 @FredLL-Avaiga @FabienLelaquais @dinhlongviolin1 would be the right persons to help you on the UX side.

ovindu-a commented 1 month ago

Hi, @namnguyen20999 , @FredLL-Avaiga , @FabienLelaquais , @dinhlongviolin1 if possible could someone let me know how to test the changes I make in the ui? I think I can close this issue if I figure it out.

FredLL-Avaiga commented 1 month ago

we have tests in backend (python: pytest), frontend (typescript: jest) and end-to-end (python: playwright) You can look at the existing tests related to the files you impact.

quest-bot[bot] commented 1 month ago

New Quest!

A new Quest has been launched in @Avaiga’s repo. Merge a PR that solves this issue to loot the Quest and earn your reward.

Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #1403 to link your PR to this Quest.

Questions? Check out the docs.

ovindu-a commented 1 month ago

@quest-bot embark

quest-bot[bot] commented 1 month ago

@ovindu-a has embarked on their Quest. 🗡

@ovindu-a has been on GitHub since 2020.
They have merged 8 public PRs in that time.
Their swords are blessed with HTML and Shell magic ✨
They haven't contributed to this repo before.

Questions? Check out the docs.

ovindu-a commented 1 month ago

@FredLL-Avaiga is there a way that I can run the frontend so I can see the changes that I make. I'm having an issue figuring out how to do that by following the docs.

FredLL-Avaiga commented 1 month ago

Of course, yes so the process is:

in taipy-gui: npm run build:dev
in taipy: npm i (one time is enough)
in taipy npm run build:dev

Then create a simple python script that shows your new feature or bug fix (something like doc\gui\examples\controls\button_action.py or others) run the script you can debug in the browser

github-actions[bot] commented 3 weeks ago

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

FredLL-Avaiga commented 3 weeks ago

@ovindu-a I don't see any PR linked to this issue. Are you still working on this ? Do you plan to propose a PR soon ?

github-actions[bot] commented 1 week ago

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

Avaiga / taipy