Closed Dr-Irv closed 1 year ago
In #85 I did a PR for fixing the typing of taipy.run().
taipy.run()
In the commit https://github.com/Avaiga/taipy/pull/85/commits/d2360ef9f05414a92af3eb4935529419a832c598#diff-16c072932d406277262b9fbaae2f8a3e77493748417cc1714e17c61c0036b256
@FabienLelaquais changed
def _run(*apps: t.Union[Gui, Rest, Core], **kwargs) -> t.Optional[Flask]:
to
def _run(*apps: t.List[_AppType], **kwargs) -> t.Optional[Flask]:
But this change is incorrect. Since apps is declared as *apps, the declaration should be _AppType to indicate that each item of apps is of type _AppType.
apps
*apps
_AppType
I could do a PR, but would be easiest for you guys to just fix this.
Irv, you are absolutely right! The next version will ultimately fix that.
Thanks a lot!
In #85 I did a PR for fixing the typing of
taipy.run()
.In the commit https://github.com/Avaiga/taipy/pull/85/commits/d2360ef9f05414a92af3eb4935529419a832c598#diff-16c072932d406277262b9fbaae2f8a3e77493748417cc1714e17c61c0036b256
@FabienLelaquais changed
to
But this change is incorrect. Since
apps
is declared as*apps
, the declaration should be_AppType
to indicate that each item ofapps
is of type_AppType
.I could do a PR, but would be easiest for you guys to just fix this.