Availity / availity-react

React components using Availity UIKit and Bootstrap 4
https://availity.github.io/availity-react
MIT License
52 stars 30 forks source link

feat(typography): converting to typescript (#1282) #1283

Closed clintonlunn closed 1 year ago

clintonlunn commented 1 year ago

closes #1282

having a go at converting a smaller package to typescript

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. Run yarn in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (yarn test). Tip: yarn test --watch TestName is helpful in development.
  5. Make sure your code passed the conventional commits check. Read more about conventional commits
codecov[bot] commented 1 year ago

Codecov Report

Merging #1283 (2d4c6f3) into master (0c0dee7) will increase coverage by 7.32%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1283      +/-   ##
==========================================
+ Coverage   86.77%   94.10%   +7.32%     
==========================================
  Files          20       19       -1     
  Lines         658      594      -64     
  Branches      167      193      +26     
==========================================
- Hits          571      559      -12     
+ Misses         87       35      -52     
Impacted Files Coverage Δ
packages/typography/src/Agreement.tsx 100.00% <100.00%> (ø)
packages/typography/src/Disclaimer.tsx 100.00% <100.00%> (ø)

... and 37 files with indirect coverage changes

clintonlunn commented 1 year ago

I changed some of the stories to hopefully be more accurate now. I thought the lorem ipsum filler text took away from the readability of the storybook page so i shortened it.