Availity / availity-react

React components using Availity UIKit and Bootstrap 4
https://availity.github.io/availity-react
MIT License
54 stars 30 forks source link

docs(feature): update Storybook change for feature #1325

Closed ncruz-av closed 1 year ago

ncruz-av commented 1 year ago

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. Run yarn in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (yarn test). Tip: yarn test --watch TestName is helpful in development.
  5. Make sure your code passed the conventional commits check. Read more about conventional commits
ncruz-av commented 1 year ago

In this change, the children parameter passed to the render function has red squiggly lines as well as the word "Feature" in the opening Feature tag. If I had the children as a feature prop in Feature.d.ts, the squiggly's go away and nothing seems to break. Should I do that?

codecov[bot] commented 1 year ago

Codecov Report

Merging #1325 (82fde19) into master (d5c6bda) will increase coverage by 5.38%. Report is 8 commits behind head on master. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
+ Coverage   92.11%   97.50%   +5.38%     
==========================================
  Files         188        3     -185     
  Lines        5290       40    -5250     
  Branches     1603        9    -1594     
==========================================
- Hits         4873       39    -4834     
+ Misses        417        1     -416     

see 185 files with indirect coverage changes