Avalanche-io / pyc4_old

Python module for the Cinema Content Creation Cloud frame work.
Apache License 2.0
2 stars 0 forks source link

Add tests for c4id #2

Closed mrjoshuak closed 8 years ago

mrjoshuak commented 8 years ago

Using the c4go project as a starting point add tests for c4ids and ids of ids (called slaces in go).

mjaganathan commented 8 years ago

Joshua, we have made the changes and committed tests to master, please review & provide comments.

mrjoshuak commented 8 years ago

There are no updated commits on GitHub. Did you do a push after the commit? It's better to do a pull request anyway. Fork the project, push your changes, then do a pull request against the c4labs c4python project.

mjaganathan commented 8 years ago

Could you email us the steps you follow to push code to master branch.

mjaganathan commented 8 years ago

Joshua, we had an issue configuring SSH keys. Now that its resolved, we have pushed the fixes for issues 1 & 2 to github for your review.

mrjoshuak commented 8 years ago

Needs test values to be updated to correct values so tests can pass.

mjaganathan commented 8 years ago

@JoshuaKolden, the code is committed to support linux/windows platforms. Please verify. Incase needed we could support for Mac OS as well.