Avalara / Communications-Developer-Content

Avalara Communications Content for Developers
16 stars 24 forks source link

Communications-Developer-Content/afc_saaspro_tax/afc_rest_apis/SDK/java maven project does not compile #46

Open shallgotransverse opened 1 year ago

shallgotransverse commented 1 year ago

First off, it was really great to find this SDK. Thanks for making it available.

It looks like there is an issue with one of the generated class names. The java file is named TSPair.java and the classname is TsPair, which will not compile. I renamed the java file (and an associated test java file) to match the classnames and it successfully compiled.

Also, I'm not sure how you are generating these projects (they appear to be generated) but it would be nice if less generic names were used and maybe something avalara specific could be used instead, for both the maven clients and the package names. It makes it difficult to work with on larger projects.

             <dependency> <!-- no one knows what this is to look at it in our artifactory instance -->
        <groupId>org.openapitools</groupId>
        <artifactId>openapi-java-client</artifactId>
        <version>v2</version>
        <scope>compile</scope>
    </dependency>

import org.openapitools.client.ApiClient; //an avalara package, so we know what ApiClient this is, would be nice import org.openapitools.client.ApiException; import org.openapitools.client.Configuration; import org.openapitools.client.api.LookupsApi; import org.openapitools.client.auth.HttpBasicAuth; import org.openapitools.client.model.PCodeLookupResult;

public class Demo {

shallgotransverse commented 1 year ago

Looks like this might have been taken care of in this pull request https://github.com/Avalara/Communications-Developer-Content/pull/33