search

Avalon-Benchmark / avalon

A 3D video game environment and benchmark designed from scratch for reinforcement learning research
https://generallyintelligent.com/avalon/
GNU General Public License v3.0
175 stars 16 forks source link

Make sentry usage configurable #11

Closed timokau closed 1 year ago

timokau commented 1 year ago

(I realize that this comment will apply here as well. I'm just in the process of cleaning up my changes to avalon, so I'll leave that here for possible consideration in the future.)

It should be possible to use avalon and the baseline agents without sending data to the pre-configured sentry project. This change makes it possible to configure a custom sentry project. It is also possible to disable logging to sentry altogether by leaving SENTRY_DSN unset [1].

[1] https://docs.sentry.io/product/sentry-basics/dsn-explainer/#what-the-dsn-does

Note that this means that SENTRY_DSN now needs to be set in order to achieve the previous default behavior. This is just a proposal based on what I think would be a better default behavior, of course I realize that you may disagree. In that case feel free to close the PR or suggest an alternative.

mx781 commented 1 year ago

Hi @timokau - thanks for all these neat, small fixes! Our sentry DSN should definitely not be hardcoded like it is and using the environment variables seems like a sensible solution. We'll merge this as soon as we finish working out the syncing nuances with our internal repo.

micimize commented 1 year ago

LGTM – rebased off of main so I can merge and use this PR to field-test our syncing script