Avalon-Benchmark / avalon

A 3D video game environment and benchmark designed from scratch for reinforcement learning research
https://generallyintelligent.com/avalon/
GNU General Public License v3.0
181 stars 16 forks source link

Changes needed to complete the tutorial_add_task tutorial #34

Open dfm794 opened 1 year ago

dfm794 commented 1 year ago

While I was able to successfully complete this tutorial, there are a number of issues in the directions. I catalog them here in case others encounter the same: Some of these issues are already known from https://github.com/Avalon-Benchmark/avalon/issues/30

(1) The tutorial directs one to install avalon per instructions in the repo's readme file. These steps fail installing godot as the install code depends on PyTorch. Installing PyTorch will fix it

(2) Step1 contains two errors

(3) Steps 2 through 5 have missing imports

(4) Step2 add import to datagen/world_creation/world_generator.py When adding the task-to-generator mapping, you must also import the task generator function in datagen/world_creation/world_generator.py, else generate_baseball_task is not defined from baseball import generate_baseball_task

(5) Step3 make sure room_position_3d is defined before use The ordering of edits in this block, if followed blindly will have rood_position_3d used before defined as previous step first set spawn_location, then target_location, but in step3 target is defined first, then spawn.

(6) Step 5 plinth_height is set, when it was meant to be min_plinth_height The following line

plinth_height = MAX_JUMP_HEIGHT_METERS + STANDING_REACH_HEIGHT + DEFAULT_FLOOR_THICKNESS + 0.1

was probably meant to be

min_plinth_height = MAX_JUMP_HEIGHT_METERS + STANDING_REACH_HEIGHT + DEFAULT_FLOOR_THICKNESS + 0.1